Hi, it's come to my attention that the move Grass Knot is still glitched on Shoddy. Many of us might remember when Grass Knot did an insane amount of damage (it OHKO'ed a specially defensive Skarmory). Fortunately, Colin patched the program relatively quick and "fixed" the problem. However, it seems that Grass Knot now does too little damage. For example, standard LO Mixape's Grass Knot only does around 87% of damage to standard Mixpert Lead when it's supposed to do 105.9% - 124.8%. I would appreciate it if this glitch would be fixed because it's getting really annoying.
-
Welcome to Smogon! Take a moment to read the Introduction to Smogon for a run-down on everything Smogon, and make sure you take some time to read the global rules.
-
Congrats to the winners of the 2023 Smog Awards!
Grass Knot still glitched
- Thread starter nyczxjay
- Start date
- Status
Yeah, they made Grass Knot ignore modifiers such as item power boosts and overgrow. I think this was done to stop the other glitch.
Would fixing it bring back the old glitch?
Ah, that's lame. But does STAB still provide additional damage? Or is it strictly weight-related damage.
I'm fairly certain that no SB bugs are going to be fixed, since SB2 is coming out soon anyway, maybe other reasons..
Seriously, my infernape once failed to ohko a freaking swampert
I don't think that's the case. Serious bugs in SB1 will I believe be fixed. And given the importance of Grass Knot (it is the only option for a number of Pokemon to hit Water-types hard), I'd say this is a serious bug.
noticed missing a OHKO today with a mewtwo while using grass knot as well :(
I've also noticed the glitch.My NPmixApe cannot KO Suicune with +2 GK....
Well, on the principle of Linus law, this is the code for Grass Knot (and Low Kick for that matter, which I presume suffers the same issue)
Now, in the standard PokemonMove class, the use method is as follows
I can't seem to find where the damage formula is in the shoddy code.
Code:
/**
* A move whose power is based on the mass of the opponent.
*/
private static class MassBasedMove extends PokemonMove {
public MassBasedMove(PokemonType type, double accuracy, int pp) {
super(type, 10, accuracy, pp);
}
public int use(BattleMechanics mech, Pokemon user, Pokemon target) {
final double mass = PokemonMass.getMass(target);
double power = (double)getPower();
int p = 0;
if (mass <= 10.0) {
p = 20;
} else if (mass <= 25.0) {
p = 40;
} else if (mass <= 50.0) {
p = 60;
} else if (mass <= 100.0) {
p = 80;
} else if (mass <= 200.0) {
p = 100;
} else {
p = 120;
}
setPower((int)(power * ((double)p) / 10.0));
int damage = super.use(mech, user, target);
setPower(10);
return damage;
}
public boolean isAttack() {
return true;
}
}
Code:
/**
* Cause a pokemon to use this move on another pokemon.
*/
public int use(BattleMechanics mech, Pokemon user, Pokemon target) {
int damage = mech.calculateDamage(this, user, target);
target.changeHealth(-damage);
return damage;
}
Then why did you make the topic?
Smogon's core programmers are tied up with the completion of Shoddy Battle 2 and shouldn't be bothered with SB1 any longer. cantab has got the right idea though; the Shoddy Battle code is available to the public, so if anybody is willing to correct it then it would be a lot more likely to be fixed (I honestly don't know how hard it is to implement new code onto the servers).
I do want to note that there was some kind of Grass Knot glitch before the present one (something about ignoring modifiers), so the solution may be a little more complex than just the code cantab presented.
Confirming. I was going to write a warstory with a friend, until we noticed Life Orb Latias' Grass Knot only did 50% to ScarfTar which is obviously wrong. Although it seems to be for only certain pokemon as my defensive Celebi did the right amount to his Tar
I originally made this topic because I wanted to request for this glitch to be fixed. However, since there was no response from the mods/programmers, I just assumed that it probably wouldn't be fixed.
Doug implemented a fix on CAP. I think it was implemented on SU as well, or should be :)
- Status